Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Python Bindings from being defined with Pybind -> Nanobind #2379

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Move Python Bindings from being defined with Pybind -> Nanobind #2379

merged 5 commits into from
Mar 7, 2025

Conversation

vprajapati-tt
Copy link
Contributor

Ticket

Problem description

  • nanobind is now supported through MLIR. It's hopefully leaner, faster, and better supported.
  • We should switch our Python bindings over to nanobind ASAP to prevent further complications

What's changed

  • Few functional changes to nanobind to support new python object storage methods.
  • Switched all of the bindings and build system from pybind11 -> nanobind.

@vprajapati-tt vprajapati-tt self-assigned this Mar 5, 2025
azecevicTT
azecevicTT approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@azecevicTT azecevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

svuckovicTT
svuckovicTT approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@svuckovicTT svuckovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

tapspatel
tapspatel approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@tapspatel tapspatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks!

@vprajapati-tt vprajapati-tt merged commit 191d311 into main Mar 7, 2025
33 checks passed
@vprajapati-tt vprajapati-tt deleted the vprajapati/issue-1774 branch March 7, 2025 18:08
odjuricicTT pushed a commit that referenced this pull request Mar 8, 2025
@vprajapati-tt @odjuricicTT
Move Python Bindings from being defined with Pybind -> Nanobind (#2379)
f60dd57 
- PR closes #1774

- `nanobind` is now supported through MLIR. It's hopefully leaner,
faster, and better supported.
- We should switch our Python bindings over to `nanobind` ASAP to
prevent further complications

- Few functional changes to nanobind to support new python object
storage methods.
- Switched all of the bindings and build system from `pybind11` ->
`nanobind`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapspatel tapspatel tapspatel approved these changes

@svuckovicTT svuckovicTT svuckovicTT approved these changes

@azecevicTT azecevicTT azecevicTT approved these changes

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@jserbedzijaTT jserbedzijaTT Awaiting requested review from jserbedzijaTT jserbedzijaTT is a code owner

@jnie-TT jnie-TT Awaiting requested review from jnie-TT jnie-TT is a code owner

@ctodTT ctodTT Awaiting requested review from ctodTT ctodTT is a code owner

@vcanicTT vcanicTT Awaiting requested review from vcanicTT vcanicTT is a code owner

Assignees

@vprajapati-tt vprajapati-tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition from Pybind to Nanobind for Python Bindings
4 participants
@vprajapati-tt @tapspatel @svuckovicTT @azecevicTT